Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add project based tailwind config file generation #9

Conversation

rajdip-b
Copy link
Contributor

@rajdip-b rajdip-b commented Nov 14, 2023

Fixes #8

Changes

  • Changes made in ./src/index.ts
  • Feature to generate tailwind.config.js or tailwind.config.ts based on project setup
  • Approval to overwrite a tailwind config in case it already exists.

@rajdip-b rajdip-b changed the title patch: Add project based tailwind config file generation fix: Add project based tailwind config file generation Nov 14, 2023
@rajdip-b
Copy link
Contributor Author

@severinlandolt Hey, can you see if the changes work?

@severinlandolt
Copy link
Member

Thanks! Will be taking a look later this week!

@qasimsiddiqui
Copy link

qasimsiddiqui commented Dec 8, 2023

Hey, I came across this PR when I faced the issue of a duplicate tailwind.config.ts file. Thanks for the PR. Hope it gets merged soon.

A small suggestion:
Do we need to ask for user input again to update the tailwind.config file? What if we change the initial message to "Running this command will install dependencies and tailwind configurations. Proceed?" Asking user input again seems to be redundant. What do you think?

@rajdip-b @severinlandolt

src/index.ts Outdated Show resolved Hide resolved
@severinlandolt severinlandolt self-assigned this Dec 13, 2023
@severinlandolt severinlandolt added the enhancement New feature or request label Dec 13, 2023
@rajdip-b
Copy link
Contributor Author

hey @severinlandolt. sorry man! i was away for a long time. I will get to this issue within a few hours and update the PR. hope this gets merged then. Also, @qasimsiddiqui, went through your suggestions. I will implement what I can!

@rajdip-b
Copy link
Contributor Author

Hey, I came across this PR when I faced the issue of a duplicate tailwind.config.ts file. Thanks for the PR. Hope it gets merged soon.

A small suggestion: Do we need to ask for user input again to update the tailwind.config file? What if we change the initial message to "Running this command will install dependencies and tailwind configurations. Proceed?" Asking user input again seems to be redundant. What do you think?

@rajdip-b @severinlandolt

From what I can understand, yes, it is a good idea to use the message you proposed. Additionally, I have extended the message so that it's a bit more elaborate. "Running this command will install dependencies and overwrite existing tailwind configurations. Proceed?"

@rajdip-b
Copy link
Contributor Author

@severinlandolt can you give it a review?

@severinlandolt severinlandolt changed the base branch from main to beta December 22, 2023 12:55
@severinlandolt severinlandolt merged commit ff76468 into tremorlabs:beta Jan 20, 2024
3 checks passed
Copy link

🎉 This PR is included in version 1.2.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generates a duplicate tailwind config file
3 participants