Cardano support

[tsusanka]

Since Cardano will be supported by Trezor T, we want python-trezor to support it as well?

Somewhat connected to trezor/trezor-core#309

[tsusanka]

@ddeath @jmuravsky each coin has at least a basic support in python-trezor - our trezorctl command line utility. Do you think you could add Cardano support here as well?

You can get inspired by Ripple's PR or Lisk's or Stellar's support. The implementation is quite straightforward. Also, while doing this, it'd be great to add some device tests (trezor/trezor-core#309), because we can't release Cardano without those. The Ripple PR includes those tests as well.

I think "get address" and "sign tx" commands are enough both for python-trezor and device tests at the moment.

[ddeath]

@tsusanka Sure we will add them. Just want to ask what about tests in trezor-core? Are they needed or not? https://github.com/trezor/trezor-core/blob/master/tests/test_apps.cardano.address.py

[tsusanka]

Yes. Both are. Basically we have two types of tests:

• unit tests, directly included in trezor-core/trezor-mcu repositories, which is exactly what you are referencing to
• device tests (aka integration tests), which are part of the python-trezor repository and are "trezor model independent". In other words those are tests that can be run against both Trezor One and Trezor T. They actually send protobuf messages to the device and expect some other protobuf messages with results

[matejcik]

Just a note: please keep in line with Ripple (#286) style, as opposed to Lisk/Stellar.
I'm currently converting the whole codebase to the new style (see #276) and I won't be accepting PRs that add methods to client.py

[ddeath]

@tsusanka added tests in #300

[ddeath]

@tsusanka same here, test are merged so this is ready for close i guess?

[tsusanka]

Yes, thank you!