Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-2668] logger.trace should have the output as attributes #1156

Open
matt-aitken opened this issue Jun 9, 2024 · 2 comments
Open

[TRI-2668] logger.trace should have the output as attributes #1156

matt-aitken opened this issue Jun 9, 2024 · 2 comments

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Jun 9, 2024

If you return data from logger.trace it should appear in the OTEL attributes from the span.

const bar = await logger.trace('key', async() => { return foo });

The same as we do for attempts.

TRI-2668

@matt-aitken matt-aitken changed the title logger.trace should have the output as attributes [TRI-2668] logger.trace should have the output as attributes Jun 9, 2024
@vr-varad
Copy link

@matt-aitken I would like to give it a attempt

@madebyfabian
Copy link
Contributor

Hi there, this is affecting us pretty much currently, since it's hard to debug complex runs when something goes wrong without having the context of what the data response was.

Would love to create a PR, just not sure where to start/what would have to be changed to archive this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants