Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per grant type configuration options #199

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 11, 2020

Resolves #105.

@HypeMC HypeMC marked this pull request as draft April 11, 2020 02:30
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #199 into v3.x will increase coverage by 0.83%.
The diff coverage is 99.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##               v3.x     #199      +/-   ##
============================================
+ Coverage     91.95%   92.79%   +0.83%     
- Complexity      386      395       +9     
============================================
  Files            58       58              
  Lines          1342     1415      +73     
============================================
+ Hits           1234     1313      +79     
+ Misses          108      102       -6     
Impacted Files Coverage Δ Complexity Δ
OAuth2Grants.php 0.00% <0.00%> (ø) 1.00 <0.00> (ø)
DependencyInjection/Configuration.php 100.00% <100.00%> (ø) 14.00 <3.00> (+9.00)
DependencyInjection/TrikoderOAuth2Extension.php 92.00% <100.00%> (+0.13%) 27.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea74bc...58e5aee. Read the comment docs.

@HypeMC HypeMC force-pushed the add-per-grant-type-config-options branch 13 times, most recently from 36130ca to 4feaa63 Compare April 12, 2020 00:22
@HypeMC HypeMC changed the title [WIP] Add per grant type configuration options Add per grant type configuration options Apr 12, 2020
@HypeMC HypeMC marked this pull request as ready for review April 12, 2020 00:34
@HypeMC HypeMC force-pushed the add-per-grant-type-config-options branch 5 times, most recently from db6b131 to 5d56d10 Compare April 18, 2020 22:40
@HypeMC HypeMC force-pushed the add-per-grant-type-config-options branch 3 times, most recently from a1aefea to 00ae936 Compare April 20, 2020 23:01
@HypeMC HypeMC force-pushed the add-per-grant-type-config-options branch from 00ae936 to 58e5aee Compare April 22, 2020 05:01
@GordonGuenther
Copy link

Would this PR also allow to enable and configure custom grant types?

@X-Coder264
Copy link
Collaborator

@GordonGuenther You can already enable and configure custom grant types without this PR -> https://github.com/trikoder/oauth2-bundle/blob/v3.x/docs/implementing-custom-grant-type.md

@X-Coder264 X-Coder264 merged commit 771e0dd into v3.x Oct 4, 2020
@X-Coder264 X-Coder264 deleted the add-per-grant-type-config-options branch October 4, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change access_token_ttl only for client_credentials
4 participants