You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that CloneCounter::decrement() unconditionally notifies all wakers in the WakerSet. If CloneCounterFuture.target were eliminated, (it is always zero) then the decrement() method could instead only notify when previously is equal to one, and save some unneeded wakes.
I haven't addressed this because I need to convince myself that this is thread safe and that with seqcst /some/ thread will always see the specific value in order to ensure waking happened
I noticed that
CloneCounter::decrement()
unconditionally notifies all wakers in theWakerSet
. IfCloneCounterFuture.target
were eliminated, (it is always zero) then thedecrement()
method could instead only notify whenpreviously
is equal to one, and save some unneeded wakes.trillium/server-common/src/clone_counter.rs
Line 78 in 8dc1d8c
The text was updated successfully, but these errors were encountered: