-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve bot incompatibility error #11751
Comments
@DanVanAtta I converted this to an issue. I wanted to look at what's broken here, but I'm not sure I fully understand the architecture. Perhaps you can help me understand this better?
|
Answering some of my questions:
I'll look at what's needed to fix. |
Looking at the console from the terminal, it seems the issue is a missing assets folder:
|
Manually copying the So we could just fix it by including assets in that zip file (it's an extra 7mb when uncompressed), but I take a quick glance at whether we can cut the dependency. |
The check for the missing assets folder was added in: Perhaps we can just disable it for headless if headless doesn't use assets. |
Looks like the dependency is unnecessary. I posted a fix here: |
Closing per the above PR. Please re-open if I missed something. |
Interesting, the |
@DanVanAtta The assert wasn't there before, it got added as part of some refactoring. |
@asvitkine I never said thank you for fixing one. I finally do so now - a sincere thank you sir. We'd still be stuck, almost a year later, had it not been for your efforts here. |
The text was updated successfully, but these errors were encountered: