Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getMarkupFromTree): Add onBeforeRender handler. #64

Merged
merged 1 commit into from
Feb 1, 2019
Merged

feat(getMarkupFromTree): Add onBeforeRender handler. #64

merged 1 commit into from
Feb 1, 2019

Conversation

avocadowastaken
Copy link
Contributor

@avocadowastaken avocadowastaken commented Jan 25, 2019

Usage of getMarkupFromTree create duplicates in some React libs like react-head.

const headTags = [];

const app = await getMarkupFromTree({
  onBeforeRender: () => {
    // Clear tags before each render.
    headTags.splice(0, headTags.length);
  },
  renderFunction: renderToString,
  tree: (
    <HeadProvider headTags={headTags}>
      <App />
    </HeadProvider>
  )
});

@trojanowski trojanowski merged commit ba2af83 into trojanowski:master Feb 1, 2019
@trojanowski
Copy link
Owner

Thanks @umidbekkarimov

@avocadowastaken avocadowastaken deleted the ssr-on-before-render branch February 1, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants