Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update React peer dependency to ^16.8.0 (alternative) #78

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

trojanowski
Copy link
Owner

BREAKING CHANGE: minimum supported (and tested) version of React is now 16.8.0

Closes #71

BREAKING CHANGE: minimum supported (and tested) version of React is now 16.8.0
@avocadowastaken
Copy link
Contributor

TBH I don't really know what benefits we get from act (as far as I know we will need it for seamless transaction from class components to functional with hooks without breaking the test). So I guess shutting it down is ok. But on the other hand - wouldn't it be easier just to shut down console.errors with act messages ? :)

@trojanowski
Copy link
Owner Author

wouldn't it be easier just to shut down console.errors with act messages

I guess that using act can be helpful in some cases. We identified one place where it's not enough to get rid of warning messages. I think that maybe in the future those warnings can help us to identify some bugs, so it's a bad idea to silence them all.

@trojanowski trojanowski merged commit 56abacc into master Feb 12, 2019
@trojanowski trojanowski deleted the chores/react-16-8 branch February 12, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants