This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: move workspaces to Ganache/ui/workspaces
#5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egacy data being migrated to here. Symlink workspaces from 'old' workspaces directory. Use fs.readdirSync along with 'withFileTypes' to avoid additional 'stat' call.
jeffsmale90
changed the title
Ganache/ui/workspaces
jeffsmale90
commented
Dec 14, 2022
Comment on lines
-100
to
103
| return spawn("cmd.exe", ["/c", "mkdir", path.join(USERDATA_PATH, "workspaces")]) | ||
| return spawn("cmd.exe", ["/c", "mkdir", path.join(USERDATA_PATH, "ui/workspaces")]) | ||
| }) | ||
| .then(()=> { | ||
| return spawn("cmd.exe", ["/c", "mkdir", path.join(USERDATA_PATH, "default")]) |
There was a problem hiding this comment.
This magic "spawn" logic is here to ensure that real directories are created (required to be able to execute "extras" [such as postgres] in correct context). It may be removed in a subsequent change.
…eting linked workspaces.
jeffsmale90
commented
Jan 10, 2023
jeffsmale90
commented
Jan 10, 2023
Comment on lines
+123
to
133
| let workspaceDirectory; | ||
| if (fse.lstatSync(this.workspaceDirectory).isSymbolicLink()) { | ||
| workspaceDirectory = fse.readlinkSync(this.workspaceDirectory); | ||
| fse.unlinkSync(this.workspaceDirectory); | ||
| } else { | ||
| workspaceDirectory = this.workspaceDirectory; | ||
| } | ||
|
|
||
| try { | ||
| fse.removeSync(this.workspaceDirectory); | ||
| fse.removeSync(workspaceDirectory); | ||
| } catch (e) { |
There was a problem hiding this comment.
At first glance this worried me, because we unlink and delete, but we're deleting the symlink, and the directory to which that symlink points.
…ng to symlink workspaces
jeffsmale90
commented
Jan 10, 2023
Comment on lines
+38
to
+46
| if (flavor === "ethereum" || flavor === "filecoin") { | ||
| // silently ignore any workspaces that aren't of a supported flavor | ||
| const linkPath = join(newWorkspacesDirectory, legacyWorkspace.name); | ||
| if (legacyWorkspace.isDirectory() && !await exists(linkPath)) { | ||
| return symlink(fullPath, linkPath, "junction"); | ||
| } | ||
| } | ||
| } catch { | ||
| // silently ignore any workspaces that fail to link |
There was a problem hiding this comment.
We now silently ignore any workspace that is not ethereum or filecoin, or that fails to parse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the workspaces directory to
<config>/Ganache/ui/workspacesin anticipation of all Ganache-UI configuration data being migrated to the<config>Ganache/uidirectory. This means that previous versions of Ganache-UI will not have visibility to "new" workspaces.During the "migration" phase of startup, all workspaces in the "old" location will have symlinks created in the "new" location - meaning that "old" workspaces are available in the "new" version of Ganache-UI.
Deleting workspaces in either version of Ganache-UI will cause the workspace to be deleted for both.