fork mainnet at the specified block number but the timestamp is not matched with it

[kl456123]

No description provided.

[kl456123]

now I have to specify chain.time manually before start forknet to force it

[davidmurdoch]

What version of Ganache?

[kl456123]

What version of Ganache?

v7.1.0

[davidmurdoch]

What command are you using?

[kl456123]

What command are you using?

use chain.time to set timestamp in options

[kl456123]

 const options = {                                                                                          
      fork: {                                                                                                  
        url: getUrl(swapParam.chainId),                                                                        
        blockNumber: swapParam.blockNumber,                                                                    
      },                                                                                                       
      wallet: { unlockedAccounts },                                                                                                                                               
      chain: {time},                                                                                               
    };

[davidmurdoch]

How are you determining that the time is wrong?

[kl456123]

otherwise I will get revert due to timestamp checks

[kl456123]

This is the expiration check.

modifier isExpired(uint256 deadLine) {
    require(deadLine >= block.timestamp, "Route: expired");
     _;
}

[davidmurdoch]

Ah, ganache uses your system time by default, even for forked blocks. We'll be adding a new option, miner.timestampIncrement, that will let you tell ganache how many seconds apart you want your blocks to be. Here is the PR for the feature: #3131

This got me thinking that when forking we really should probably always set the time to the for block's timestamp (unless the user set a different time). 🤔

[kl456123]

Ah, ganache uses your system time by default, even for forked blocks. We'll be adding a new option, miner.timestampIncrement, that will let you tell ganache how many seconds apart you want your blocks to be. Here is the PR for the feature: #3131

This got me thinking that when forking we really should probably always set the time to the for block's timestamp (unless the user set a different time). 🤔

Yep, If that, it will not make any more confusion.:smiley:

[StillFantastic]

Agree, it makes more sense to use forked blocks' timestamp

[cliffoo]

#3131 is merged! Closing for Issue Maintenance. Thanks for opening this 🙂

[davidmurdoch]

Reopening as I do think it makes sense for the default behavior to be based off of the forked blocks timestamp. Though this might have to wait until Ganache v8.0