Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Gas Estimation: tests dont work with [email protected] and later #440

Closed
shanefontaine opened this issue Jul 2, 2019 · 5 comments
Closed

Comments

@shanefontaine
Copy link

shanefontaine commented Jul 2, 2019

Running any version of ganache-cli >=6.4.2 (Gas Exactimation) breaks tests on this repository. In reviewing the [email protected] changelog, I read to submit an issue here if an OOG error is experienced.

Expected Behavior

By following the "Test" section of the README, I expect all tests to run successfully (with npm run test). This is what happens prior to [email protected].

To run ganache-cli, I am not using the npm script, but rather using ganache-cli -p 8545 -m "asset member awake bring mosquito lab sustain muscle elephant equip someone obvious" -a 100

Current Behavior

error=Error: Returned error: VM Exception while processing transaction: out of gas

ganache-cli versions 6.4.2, 6.4.3, and 6.4.4 produce the above error when running npm run test.

Steps to Reproduce (for bugs)

# Install Ganache-cli globally:
npm install --global ganache-cli

# Install Truffle globally:
npm install --global [email protected]

# Install local node dependencies:
npm install

# Compile contracts
npm run compile

# Run ganache-cli
ganache-cli -p 8545 -m "asset member awake bring mosquito lab sustain muscle elephant equip someone obvious" -a 100

# Run contracts test suite
npm run test

Context

This was discovered when running tests on this repository.

Your Environment

@shanefontaine shanefontaine changed the title Gas Estimation: 6.4.2 broke tests Gas Estimation: tests dont work with [email protected] and later Jul 2, 2019
@davidmurdoch
Copy link
Member

Hey there @shanefontaine! Thanks for opening this issue!

I just released a new beta with a gas estimation fix a few minutes ago! I haven't even published the release notes yet!

Do you mind trying it out and letting me know if it fix the issue for you?

To update to the beta run:
npm install --global ganache-cli@beta

@shanefontaine
Copy link
Author

Great timing. This beta version works perfectly. I'll go ahead and close this issue.

@shanefontaine
Copy link
Author

@davidmurdoch is there going to be any note or warning on 6.4.2-6.4.4 that says that there may have been a breaking change in these versions? Or will this fix be included in a major semantic change soon? I am wondering if there are any other people that have run into this issue and have not read the one line in the Changelog.

@davidmurdoch
Copy link
Member

This wasn't a breaking change (at least not in the semver definition of "breaking"). This was a regression/bug. The next patch release will fix this bug.

@shanefontaine
Copy link
Author

That makes sense. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants