Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fix eth_sign #1716

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix eth_sign #1716

merged 2 commits into from
Dec 3, 2021

Conversation

MicaiahReid
Copy link
Contributor

Removed chainId from eth_sign.

Fixes #972

@MicaiahReid MicaiahReid merged commit e806822 into develop Dec 3, 2021
@MicaiahReid MicaiahReid deleted the fix/eth_sign branch December 3, 2021 16:33
@sylar123abc
Copy link

Hi MicaiahReid, it seems that this error came out again, in this fix you were importing ecsign from ethereumjs-utils, but from 7.7.0 this ecsign is imported from @ganache/utils which reintroduced the signature inconsistency

@davidmurdoch
Copy link
Member

@sylar123abc fixing in #4527

@sylar123abc
Copy link

@davidmurdoch you're the king 🔥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior of web3.eth.sign between ganache-cli and hdwallet-provider
3 participants