Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Truffle should succeed when there are warnings when options.strict is false #296

Closed
tharidu opened this issue Nov 5, 2016 · 1 comment
Closed

Comments

@tharidu
Copy link

tharidu commented Nov 5, 2016

Issue

Currently in lib/compiler.js strict == false is not checked, hence warnings are considered as errors. But when strict = false, it should succeed and compile the contracts

Steps to Reproduce

Comment the pragma declaration

Expected Behavior

It should show a warning but still compile the contracts

Actual Results

Right now, strict flag is not respected so compilation fails

@tcoulter tcoulter added this to the 3.0.0 milestone Dec 20, 2016
@tcoulter
Copy link
Contributor

This is fixed in truffle-compile v1.1.2. You can get this upgrade now by uninstalling Truffle and then reinstalling it, to ensure the new dependency is downloaded. It will also go out with the next release of Truffle, 3.1.2. Thanks for the issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants