Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Circular dependency between @truffle/resolver and @truffle/compile-solidity #5244

Closed
haltman-at opened this issue Jun 29, 2022 · 1 comment
Closed
Assignees

Comments

@haltman-at
Copy link
Contributor

Issue

We currently have a circular dependency between @truffle/resolver and @truffle/compile-solidity.

The package @truffle/compile-solidity imports @truffle/resolver as a dev dependency, because it uses it in tests. Meanwhile, the package @truffle/resolver imports the range utils from @truffle/compile-solidity. (Yes, one of the legs of this circularity is a dev dependency, but even that will cause problems for lerna.)

Since the range utils are the only part of @truffle/compile-solidity that's imported, the simplest solution might be to simply split the range utils off into their own package? Since that sounds easier to me than eliminating @truffle/resolver from the compile-solidity tests...

Environment

  • Truffle version (truffle version): 5.5.19
@haltman-at
Copy link
Contributor Author

Huh, I thought #5445 was supposed to resolve this, but it's still around...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants