Allow non-numeric immutable keys in contract-schema and add test of Yul immutable recognition #4746
Conversation
haltman-at
requested review from
gnidan,
cds-amal,
tenthirtyone,
fainashalts and
eggplantzzz
haltman-at
changed the title
There was a problem hiding this comment.
Edit: Actually, you know what, I was a little bit unsatisfied with this, so I went back and added a test -- not a test of the contract-schema change of course, that should have no functional effect at the moment; but a test that yes, the debugger can indeed use Yul's immutableReferences to correctly recognize Yul code with immutables in it (without any code changes to codec or the debugger necessary :) ). Obviously this required updating the debugger tests to Solidity 0.8.12...
YES! I love this.
| @@ -25,7 +25,7 @@ export async function prepareContracts(provider, sources = {}, migrations) { | |||
|
|
|||
| config.compilers = { | |||
| solc: { | |||
| version: "0.8.9", | |||
| version: "0.8.12", | |||
| settings: { | |||
| optimizer: { enabled: false, runs: 200 }, | |||
There was a problem hiding this comment.
This is not part of this PR's changes but I'm curious what this optimizer settings does, enabled is false and runs is 200?
There was a problem hiding this comment.
Oh, yeah, runs does nothing if enabled is false. This is just how that's been, I've never bothered to alter that. I assume it's copied from the config defaults, which is also like that.
As of Solidity 0.8.12, we can now get
immutableReferencesfrom Yul contracts that use immutables. However, the keys for these are not numeric AST IDs, but rather simply the names of the immutables. So, I'm taking out thepatternPropertiesand replacing it withadditionalProperties, since the keys can now be anything.This PR doesn't do the work of allowing us to actually do things with Yul immutables, like decode them. I figure that can come later (I've put up issue #4747 for that). This is just updating the contract schema.
Note: I checked our existing immutable-handling code and as best I can tell this shouldn't screw any of it up.
Edit: Actually, you know what, I was a little bit unsatisfied with this, so I went back and added a test -- not a test of the
contract-schemachange of course, that should have no functional effect at the moment; but a test that yes, the debugger can indeed use Yul's immutableReferences to correctly recognize Yul code with immutables in it (without any code changes to codec or the debugger necessary :) ). Obviously this required updating the debugger tests to Solidity 0.8.12...