Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No type hints for ProvDocument.agent etc. #143

Open
Joe-Heffer-Shef opened this issue Apr 13, 2021 · 1 comment
Open

No type hints for ProvDocument.agent etc. #143

Joe-Heffer-Shef opened this issue Apr 13, 2021 · 1 comment

Comments

@Joe-Heffer-Shef
Copy link

It would be easier to use the code if type hints were used here
https://github.com/trungdong/prov/blob/master/src/prov/model.py#L1829
like this:

def agent(self, identifier, other_attributes=None) -> ProvAgent:
@trungdong
Copy link
Owner

Thanks for the suggestion. This is next on my plan for version 2.1. I'm in fact half way through it at the moment. I hope to get it done and released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants