Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum length for icon field causes tests to fail #47

Open
dmpiergiacomo opened this issue Dec 14, 2020 · 0 comments
Open

Maximum length for icon field causes tests to fail #47

dmpiergiacomo opened this issue Dec 14, 2020 · 0 comments

Comments

@dmpiergiacomo
Copy link

dmpiergiacomo commented Dec 14, 2020

Hi,

I believe that forwarding an icon of 128 bytes causes test_rk_maximum_list_capacity_per_rp_nodisplay and test_rk_maximum_size_nodisplay to fail against the Solo authenticator when PIN is provided.

I should investigate more, but from a quick look it seems like Solo sets the last usable byte of the icon field to 0. Should then the tests above forward an icon of 127 bytes instead, or should the Solo authenticator code be modified to return 128 bytes?

Notice that the current version of the Solo authenticator hits other errors before replicating the above. Consider this pull request to solve those errors and reproduce what has been written here above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant