Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Widget Enhancement and issues #108

Open
Pooya-Oladazimi opened this issue Jul 10, 2024 · 1 comment
Open

Metadata Widget Enhancement and issues #108

Pooya-Oladazimi opened this issue Jul 10, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Pooya-Oladazimi
Copy link
Collaborator

Pooya-Oladazimi commented Jul 10, 2024

Some enhancement suggestions for the metadata widget

https://ts4nfdi.github.io/terminology-service-suite/comp/latest/?path=/docs/react_metadatawidget--docs

  • The term label should be bold and on top
  • The tabs should be optional. Users can decide which tab to show
  • Backlink to the TS: The term should be a link (if the user wants) to the corresponding terminology service. (show the target term in the target TS) --> currently is supported in the Iri Widget
  • Question: what if the user only has an Iri? (type is unknown).

Issues:
The doc seems to be not correct. It looks like a search doc. Term fetching in OLS does not have these options:
Screenshot from 2024-07-10 10-40-24

Types options have strange values (empty and invalid string)
Screenshot from 2024-07-10 10-42-42

@Pooya-Oladazimi Pooya-Oladazimi added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 10, 2024
@VincentKneip
Copy link
Collaborator

I agree that the entity label should be bold and moved over the iri. The breadcrumb should stay on top in my opinion, similar to the appearance on EBI-OLS: https://www.ebi.ac.uk/ols4/ontologies/hp/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FHP_0000819

Regarding your question: If the entityType is unknown, the empty string option should be active on the entityType property. This has the same effect as passing undefined to the property, and leads to the widget figuring the correct value of entityType out by itself.

The value INVALID STRING was introduced for testing purposes on incorrect input values. When selected, an error is thrown on the console:
grafik

You're right with the docs for the parameter property. Currently, all widgets having the parameter property incorrectly have a doc for search parameters. This has to be corrected for all widgets not using the search endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants