From 6cf30e4523dcada4174cfaaeb591eded2a8198ee Mon Sep 17 00:00:00 2001
From: Nathan Reese <reese.nathan@elastic.co>
Date: Fri, 4 Oct 2024 09:57:51 -0600
Subject: [PATCH] [presentation team] Fix SASS mixed-declarations deprecation
 warnings (#194721)

closes https://github.com/elastic/kibana/issues/190895,
https://github.com/elastic/kibana/issues/190896, and
https://github.com/elastic/kibana/issues/190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../dashboard/public/dashboard_app/top_nav/editor_menu.scss   | 4 ++--
 .../expression_error/public/components/debug/debug.scss       | 2 +-
 .../public/components/vis/input_control_vis.scss              | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.scss b/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.scss
index 0f463926908f3d..4b1a1d9b27d57d 100644
--- a/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.scss
+++ b/src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.scss
@@ -1,6 +1,6 @@
 .dshSolutionToolbar__editorContextMenu {
-  @include euiScrollBar;
-  @include euiOverflowShadow;
   max-height: 60vh;
   overflow-y: scroll;
+  @include euiScrollBar;
+  @include euiOverflowShadow;
 }
diff --git a/src/plugins/expression_error/public/components/debug/debug.scss b/src/plugins/expression_error/public/components/debug/debug.scss
index e4d14229756754..fcc046cae7e967 100644
--- a/src/plugins/expression_error/public/components/debug/debug.scss
+++ b/src/plugins/expression_error/public/components/debug/debug.scss
@@ -4,10 +4,10 @@
   height: 100%;
 
   .canvasDebug__content {
-    @include euiScrollBar;
     width: 100%;
     height: 100%;
     overflow: auto;
     padding: $euiSize;
+    @include euiScrollBar;
   }
 }
diff --git a/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss b/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
index 322573446f7629..42ec14a70b02eb 100644
--- a/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
+++ b/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
@@ -1,9 +1,9 @@
 .icvContainer__wrapper {
-  @include euiScrollBar;
   min-height: 0;
   flex: 1 1 0;
   display: flex;
   overflow: auto;
+  @include euiScrollBar;
 }
 
 .icvContainer {