Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluebird dependency #411

Closed
dandv opened this issue Feb 12, 2018 · 3 comments
Closed

Bluebird dependency #411

dandv opened this issue Feb 12, 2018 · 3 comments

Comments

@dandv
Copy link

dandv commented Feb 12, 2018

Any plans to remove the Bluebird dependency now that Promises have been natively supported for a while?
@dandv dandv mentioned this issue Feb 20, 2018
Closed
@dandv
Copy link
Author

dandv commented Feb 20, 2018

Found @peterpme's twitter-lite

@ttezel
Copy link
Owner

ttezel commented May 31, 2018

I don't plan to remove Bluebird since I believe Promise support was added natively in Node v0.12, and twit supports earlier versions of Node.

@ttezel ttezel closed this as completed May 31, 2018
@dandv
Copy link
Author

dandv commented Jul 1, 2018 •
edited
Loading

Versions of node earlier than v0.12 have been in End-of-Life stage for more than a year. How many twit users still use such old Node versions?

The vast majority of twit users use current Node versions, which support native Promises. Is it worth penalizing all these users for the sake of supporting Node <v0.12?

If twit switched to native Promises in the next major release, those who need Node <v0.12 for some reason can simply continue to use the current version of twit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dandv @ttezel