Add support for AbortSignal #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5aa6c66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
klippx
force-pushed
the
abort-signal
branch
from
a0a88d0
to
c448f64
Compare
klippx
force-pushed
the
abort-signal
branch
from
c448f64
to
b5ce4bc
Compare
klippx
force-pushed
the
abort-signal
branch
from
5886595
to
3f10665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal
It is standard practice for all APIs capable of using the AbortController API to take the signal property of an AbortController class instance as an argument. In Mappersmith case, we are the glue between the user and Fetch / HTTP and these APIs support AbortController API. Let's get out of the way and let people use it if they need.