Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Override handleSIGINT in puppeteer #75

Open
imlinder opened this issue Mar 28, 2023 · 0 comments
Open

[FEATURE REQUEST] Override handleSIGINT in puppeteer #75

imlinder opened this issue Mar 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@imlinder
Copy link

Is your feature request related to a problem? Please describe.
When running timecut, the SIGINT event stops working as expected. Puppeteer has a launchoption to not handle SIGINT (defaults to closing the browser process): https://pptr.dev/api/puppeteer.launchoptions.handlesigint.
This fix will be useful if you want to be able to make sure a capture completes before terminating the process, or doing other cleanups.

Describe the solution you'd like
Timesnap could forward config.handleSIGINT to puppeteer launchOptions: 4b4be5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant