fix(this): update tests; listeners should not have "this" context

tunnckoCoreLabs · Mar 17, 2017 · 534f7a3 · 534f7a3
1 parent 84b7e9a
commit 534f7a3
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 8 deletions.
diff --git a/dist/dush.common.js b/dist/dush.common.js
@@ -252,8 +252,8 @@ function dush () {
     emit: function emit (name) {
       if (name !== '*') {
         var args = [].slice.call(arguments);
-        (all[name] || []).map(function (handler) { handler.apply(app, args.slice(1)); });
-        (all['*'] || []).map(function (handler) { handler.apply(app, args); });
+        (all[name] || []).map(function (handler) { handler.apply(undefined, args.slice(1)); });
+        (all['*'] || []).map(function (handler) { handler.apply(undefined, args); });
       }
 
       return app

diff --git a/dist/dush.es.js b/dist/dush.es.js
@@ -250,8 +250,8 @@ function dush () {
     emit: function emit (name) {
       if (name !== '*') {
         var args = [].slice.call(arguments);
-        (all[name] || []).map(function (handler) { handler.apply(app, args.slice(1)); });
-        (all['*'] || []).map(function (handler) { handler.apply(app, args); });
+        (all[name] || []).map(function (handler) { handler.apply(undefined, args.slice(1)); });
+        (all['*'] || []).map(function (handler) { handler.apply(undefined, args); });
       }
 
       return app

diff --git a/dist/dush.umd.js b/dist/dush.umd.js
diff --git a/dist/dush.umd.js.gz b/dist/dush.umd.js.gz
diff --git a/dist/dush.umd.js.map b/dist/dush.umd.js.map
diff --git a/src/index.js b/src/index.js
@@ -252,8 +252,8 @@ export default function dush () {
     emit (name) {
       if (name !== '*') {
         var args = [].slice.call(arguments);
-        (all[name] || []).map((handler) => { handler.apply(app, args.slice(1)) });
-        (all['*'] || []).map((handler) => { handler.apply(app, args) })
+        (all[name] || []).map((handler) => { handler.apply(undefined, args.slice(1)) });
+        (all['*'] || []).map((handler) => { handler.apply(undefined, args) })
       }
 
       return app

diff --git a/test.js b/test.js
@@ -226,3 +226,16 @@ test('should support to emit any number of arguments', function (done) {
     })
     .emit('zazzie', 1, 2, 3, 4, 5)
 })
+
+test('should event listeners not have `this` context', function (done) {
+  function listener (hi) {
+    test.strictEqual(hi, 'hello world')
+    test.strictEqual(this, undefined)
+    done()
+  }
+
+  var app = dush()
+  app.on('ctx', listener)
+  app.once('ctx', listener)
+  app.emit('ctx', 'hello world')
+})