Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database connection builder API? #1635

Open
penberg opened this issue Aug 5, 2024 · 1 comment
Open

Improve database connection builder API? #1635

penberg opened this issue Aug 5, 2024 · 1 comment
Labels
embedded replicas enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@penberg
Copy link
Collaborator

penberg commented Aug 5, 2024

The new_remote_replica() and new_local_replica() names are weird because in both cases the replica is local. The difference is just with how they are synced.

My proposal is to keep new_local() and new_remote() but add additional with_remote_sync() and with_file_sync() methods to the builder for local database variant.
@penberg penberg added enhancement New feature or request help wanted Extra attention is needed question Further information is requested embedded replicas labels Aug 5, 2024
@LucioFranco
Copy link
Contributor

I think that makes a lot of sense, lets line this up for the next breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
embedded replicas enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@penberg @LucioFranco