Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSelect prop fallback-option's better type hint #1327

Closed
sigmarising opened this issue Oct 11, 2021 · 1 comment
Closed

NSelect prop fallback-option's better type hint #1327

sigmarising opened this issue Oct 11, 2021 · 1 comment
Labels
feature request New feature or request

Comments

@sigmarising
Copy link

This function solves the problem (这个功能解决的问题)

Help make dev with vscode better.

Expected API (期望的 API)

The offical docs show that fallback-option's type is false | (value: string | number) => SelectOption

offical docs

But actually I found in .d.ts file is (value: string | number) => false | SelectOption, which made the vscode give me an type error when I put the false value into the prop.

error of vscode

detail error

.d.ts file

However, even vscode give me this error, I can still compile my code and run it successfully.

@github-actions github-actions bot added the feature request New feature or request label Oct 11, 2021
@07akioni
Copy link
Collaborator

This is a bug, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants