Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Delete work #294

Open
ponchofiesta opened this issue Feb 13, 2019 · 2 comments
Open

Delete work #294

ponchofiesta opened this issue Feb 13, 2019 · 2 comments
Labels
Core Mediaserver Core Module enhancement New feature or request

Comments

@ponchofiesta
Copy link
Contributor

I think we talked about it. Should there be a way to delete a work? Actually the user would need to delete a work manually from the DB and filesystem.

I assume this could be done with an action.

@ponchofiesta ponchofiesta added enhancement New feature or request Core Mediaserver Core Module labels Feb 13, 2019
@pbroman
Copy link

pbroman commented Feb 13, 2019

That would probably be a relatively simple action, something similar to the cache delete action. But I'm afraid, this case is a bit more complex. If we add it to the ui, we must extend the ui with a warning "You are about to ... This cannot be undone...". Otherwise, you might accidentally delete a lot of works.
Maybe we should then also add a deleted flag to the work table, otherwise, there will be no possibility to know, which works were deleted. And should the search then display deleted works or not? I suppose, you must have a possibility to select that. And if a work with the same ID is imported later, the deleted flag has to be unset. ...

@ponchofiesta
Copy link
Contributor Author

ponchofiesta commented Feb 15, 2019

I also think now an action is the wrong way. Normally before and after performing an action the work is still available. Otherwise performRequested() would throw an error. Of cause, if you keep this in mind, it would work with performImmidiately().

Perhaps a place would be WorkService.deleteWork(). Than we need a CLI command and an UI method of taking care of this dangerous step.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core Mediaserver Core Module enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants