You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the failure_limit option was added back on Dec-01, the code to maintain backwards compatibility was added incorrectly. The code checks for option.failurelimit to not strictly equal null. If the option is omitted (as it should be going forward), the check still returns true (null !== undefined) and then incorrectly overrides any specified value for option.failurelimit to 0. I believe the proper check should be:
if (undefined !== options.failurelimit) {}
The text was updated successfully, but these errors were encountered:
When the failure_limit option was added back on Dec-01, the code to maintain backwards compatibility was added incorrectly. The code checks for option.failurelimit to not strictly equal null. If the option is omitted (as it should be going forward), the check still returns true (null !== undefined) and then incorrectly overrides any specified value for option.failurelimit to 0. I believe the proper check should be:
if (undefined !== options.failurelimit) {}
The text was updated successfully, but these errors were encountered: