Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetComputerNameEx support #365

Merged
merged 2 commits into from
Sep 4, 2014
Merged

Added GetComputerNameEx support #365

merged 2 commits into from
Sep 4, 2014

Conversation

lgoldstein
Copy link
Contributor

As specified in MSDN:GetComputerNameEx

@dblock
Copy link
Member

dblock commented Sep 3, 2014

Very good, update CHANGELOG, please?

@lgoldstein
Copy link
Contributor Author

What file do you mean ? There are several files named changelog (none in uppercase). Also, isn't the commit log the changelong ?

@dblock
Copy link
Member

dblock commented Sep 3, 2014

@lgoldstein
Copy link
Contributor Author

Done - updated and pushed to the forked branch - how do I re-submit the changes (or is it done automatically) ?

@twall
Copy link
Contributor

twall commented Sep 4, 2014

Changes to the branch on which the PR is based are propagated automatically.

CHANGES.md is a more concise form for changes than the commit history. You might have dozens of commit changes that implement “add feature X”.

Thanks for the contribution.

On Sep 4, 2014, at 12:56 AM, Lyor Goldstein [email protected] wrote:

Done - updated and pushed to the forked branch - how do I re-submit the changes (or is it done automatically) ?


Reply to this email directly or view it on GitHub.

@lgoldstein
Copy link
Contributor Author

@twall Thanks for the explanation - I am not used to using pull requests so I was not aware of its cool features.

dblock added a commit that referenced this pull request Sep 4, 2014
@dblock dblock merged commit ee677e3 into java-native-access:master Sep 4, 2014
@lgoldstein lgoldstein deleted the get-computer-name-ex branch September 4, 2014 12:03
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
Motivation:

07d872f added support for 0-RTT when on the client-side by adding client side session caching. While the implementation worked we missed to add a unit test

Modifications:

- Add a unit test

Result:

Test for SSL session re-use on the client-side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants