Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petition for ".icon" and prefix ".icon-" instead of ".glyphicon" and prefix ".glyphicon-" #10440

Closed
tlindig opened this issue Sep 4, 2013 · 1 comment

Comments

@tlindig
Copy link
Contributor

tlindig commented Sep 4, 2013

At first. Thank you all the Bootstrap 3 developers for your great work.

For icons, Bootstrap 3.0 switched from "icon-" to "glyphicon" "glyphicon-".

mbo written here #10201 (comment):

Overall, it comes down to performance. The attribute selectors we used in 2.x just don't cut it in larger projects and classes are way more performant. It also fits with our base and modifier class approach elsewhere in the project.

and here: #8332 "Remove Glyphicons"

  1. Makes Glyphicons more readily available to the masses, with or without Bootstrap's integration.
  2. Keeps the core project as lean as possible with regards to number of files, build processes, versioning, and more.
  3. Enables the community to more easily swap other icon libraries in and out.

So the first target is better performance. We get it by using base class and a modifier class.

And the second target is more easily swap other icon libraries.

Using the product name "glyphicon" in the class names work against this!

It links bootstrap 3 stronger to glyphicon as ever before. It brings a lot of trouble and only ugly solutions for providers of icon sets and also for users of icon set.

See here for details: FortAwesome/Font-Awesome#940 (comment)

But why?

Using "icon" as base class and "icon-" as prefix for modifier classes (or may be "bs-icon" and "bs-icon-") would avoid many of these problems.

I beg of you the bootstrap developers, do not longer take a product name of a special icon set as default class name in bootstrap.

Is there anybody who support this wish?
Please add a vote.

ps: Sorry for my English, I still try to find the right words with a dictionary.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 4, 2013

Duplicate of #10201.

@cvrebert cvrebert closed this as completed Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants