Class "in" is not removed from collapsed menu when screen became bigger

[ghost]

In this link http://jsfiddle.net/tZXTv/

1 -

has two classes: collapse navbar-collapse

2 -

the class "collapse" has his position changed, and a class "in" is add

3 - If resize the screem without click on this

this classes "navbar-collapse collapse in" aren't change

and why? because if i want to style the collapsed menu i need some class of reference, the only one is "in", and if this class is not removed i dont know what I can use a reference to style.

[hnrch02]

Duplicate of #11653, please search next time.

[cvrebert]

However, that issue was punted 3 months ago. Perhaps we can actually deal with it now.

[ghost]

Solved with this code:

$(window).on('resize', function () {
  if (window.innerWidth > 768) $('.navbar-collapse').removeClass('in')
})

customized from #11653

hope to see this kind of code in standard bootstrap soon, this is useful.

[fat]

@cvrebert i'd rather not add code like that to the dropdown plugin… maybe a good candidate for docs?

$(window).on('resize', function () {
  if (window.innerWidth > 768) $('.navbar-collapse').removeClass('in')
})

[fat]

or we could just add to the bottom of the collapse plugin with a comment…feels kinda jank tho

[cvrebert]

No, I think it's a good candidate for actually including in the plugin. 😀 We just need to un-hardcode the width and maybe put it inside a method if you want it to be opt-in. Having the navbar be broken like this feels jank.

[mdo]

Yeah, it'd be awesome to have the collapse plugin use a data attribute for the collapse. I don't think that's something we can just roll into v3.x though, no?

[cvrebert]

Hmm, why not? As long as we fall back to the current lack-of-behavior when the attribute is absent, seems like it should be fine.

[mdo]

Punting to v4 because I want to rethink a bunch of this and complicating the plugin more sounds like a bad idea to me right now. Also I think the JS and CSS to make the current behavior and the new stuff happen would probably be a shit show.

[cvrebert]

Similar: google/web-starter-kit#79