Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.caret visually broken in IE11 when zooming #17455

Closed
Inspyro opened this issue Sep 3, 2015 · 11 comments
Closed

.caret visually broken in IE11 when zooming #17455

Inspyro opened this issue Sep 3, 2015 · 11 comments
Labels

Comments

@Inspyro
Copy link

Inspyro commented Sep 3, 2015

When using the non-minified version of the bootstrap.css you use a trick for ie8 and below by defining the .caret style like the following "border-top: 4px solid \9;". IE11 (in edge mode) won't understand this and therefore does not render the border at all - which makes the caret being rendered as broken in the middle.
When removing the space (between solid and \9) this does not happen - this is why with the minified version of bootstrap this works.

Please fix this in Bootstrap v3 and consider it for v4.

PS:
You could use a better solution instead of css hacks - see this stack overflow post:
http://stackoverflow.com/questions/814219/how-does-one-target-ie7-and-ie8-with-valid-css

@cvrebert cvrebert changed the title Dropdown (Caret) - Visually broken in IE11 - Bootstrap v3 - BUG Dropdown (Caret) - Visually broken in IE11 Sep 3, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Sep 3, 2015

@Inspyro Which exact version are you using? v3.3.5?

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 3, 2015

@Inspyro I can't reproduce with http://jsbin.com/lazivo/edit?html,output
caret
With absurd zoom:
zoom

@cvrebert cvrebert changed the title Dropdown (Caret) - Visually broken in IE11 .caret visually broken in IE11 Sep 3, 2015
@Inspyro
Copy link
Author

Inspyro commented Sep 3, 2015

Hey, I just checked it again, with 100% zoom everything works as expected. But try the same example with 105% or 110% zoom in IE11 - it does not work anymore. However the minified version also works with zoom.

dropdown-ie11-105

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 3, 2015

like the following "border-top: 4px solid \9;". IE11 (in edge mode) won't understand this

It's not supposed to understand that since that's supposed to be an IE8-specific hack.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 3, 2015

try the same example with 105% or 110% zoom in IE11 - it does not work anymore

We don't really support zooming: http://getbootstrap.com/getting-started/#support-browser-zooming

@cvrebert cvrebert changed the title .caret visually broken in IE11 .caret visually broken in IE11 when zooming Sep 3, 2015
@Inspyro
Copy link
Author

Inspyro commented Sep 3, 2015

Ok i understand. However in this case the fix is rather easy. you just need to remove the space between the "solid" and the "\9".

@fschmied
Copy link

fschmied commented Sep 4, 2015

See also #16203. IMO, even though zooming makes the issue visible (and zooming isn't really supported by Bootstrap), the issue should still be fixed. Essentially, IE 11 doesn't render the border-top of the caret because it considers the "solid \9" with a space to be invalid CSS (see screenshot of F12 toolbar below). It's more or less good luck that the caret works without a top border at 100% zoom.

Removing the space seems to be an easy fix.

image

@mdo mdo added this to the v3.3.6 milestone Sep 5, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Sep 5, 2015

Just removing the space is not the right fix. The \9 is there for the sole purpose of making that CSS property declaration only apply in IE8 (see http://browserhacks.com/#hack-ab1bcc7b3a6544c99260f7608f8e845e ).
But I can confirm that IE11 (but thankfully not Edge) is unexpectedly deeming solid\9 to be valid (even though it isn't), so we're going to need to tweak something somewhere. Maybe this is another wrinkle that clean-css needs to take into account.

@cvrebert
Copy link
Collaborator

Refs #16384, #16258

@theJian
Copy link

theJian commented Sep 1, 2016

BTW, It also exits on Edge browser.

@mdo
Copy link
Member

mdo commented Sep 5, 2016

Bootstrap 3 is no longer being officially developed or supported.

All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!

<3,
@mdo and team

@mdo mdo closed this as completed Sep 5, 2016
@mdo mdo modified the milestone: v3.3.8 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants