Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause on the Carousel dont work in Google Chrome #21599

Closed
1letter opened this issue Jan 7, 2017 · 8 comments
Closed

Pause on the Carousel dont work in Google Chrome #21599

1letter opened this issue Jan 7, 2017 · 8 comments

Comments

@1letter
Copy link

1letter commented Jan 7, 2017

OS: Windows 10
Browser: Google Chrome Version 55.0.2883.87m

Problem: Pause on the Carousel dont work

The Chrome Browser on my Desktop don't stop the Slide when i hover the Mouse over the Carousel. The check of !('ontouchstart' in document.documentElement) evaluate to True and the Mouseenter and Mouseleave Event is not registered. I think another check is needed.

@patrickhlauke
Copy link
Member

yes, checking for ontouchstart is bound to give false positives (or rather, it doesn't test what some authors expect) and will only get more muddy in the near future https://bugs.chromium.org/p/chromium/issues/detail?id=392584

also, this doesn't seem to take into account scenarios where there are BOTH a mouse and a touchscreen. in short, this code (and any other instances of conditionals depending on ontouchstart being present, e.g. in

if ('ontouchstart' in document.documentElement &&
) will need to be rethought. /cc @mdo

@Johann-S
Copy link
Member

For me pause (on hover) Carousel work, see this CodePen (BS 4 Alpha 6) : http://codepen.io/Johann-S/pen/oBedMZ
But we should follow what @patrickhlauke said

@xsalto-camille
Copy link

xsalto-camille commented Feb 15, 2017

+1 not working with Chrome and @Johann-S your CodePen not working for me on Chrome

Workaround found at #1048 :

$('.carousel').hover(function () { 
  $(this).carousel('pause') 
}, function () { 
  $(this).carousel('cycle') 
})

@Johann-S
Copy link
Member

Johann-S commented Feb 15, 2017

I checked once again my CodePen and everything is working

This is my version of Chrome (on Desktop) : 56.0.2924.87 (64-bit)

@xsalto-camille
Copy link

My version is 56.0.2924.87 (64-bit) too !

I work on Windows 10 with an hybrid PC (Lenovo Yoga) connected to an external screen...

@KevHaitch
Copy link

+1 noworky on Window 10, Chrome 56.0.2924.87, touchscreen Samsung ATIV. Fixed with xsalto-camille's jQuery workaround. Thanks.

@gijsbotje
Copy link
Contributor

so is this a touch issues or also a mouse hover issue?
i'm on a macbook pro with macos 10.12.5 and chrome 59.0.3071.115 and the mouse hover seems to work, in the inspector the touch>hold kind of hover is also working

@patrickhlauke
Copy link
Member

Should all be fixed by #22442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants