Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden class added by Modernizr causes blank page when combined with bootstrap #21762

Closed
tschallacka opened this issue Jan 17, 2017 · 2 comments

Comments

@tschallacka
Copy link

Relevant: Modernizr/Modernizr#2147

Reproduce:
make html page with bootstrap
add Modernizr.js compiled with the following modernizr-config.json

{
  "minify": true,
  "options": [
    "setClasses"
  ],
  "feature-detects": [
    "test/dom/hidden",
  ]
}

suggested solution:

make

visibility: hidden !important;

html .hidden instead of just .hidden

@mdo mdo modified the milestone: v4.0.0-beta.2 Jan 21, 2017
@ryanseddon
Copy link

For reference: Modernizr/Modernizr#2147 (comment)

@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-beta.2 Mar 5, 2017
@mdo mdo added the has-pr label Mar 5, 2017
@mdo
Copy link
Member

mdo commented Mar 5, 2017

This won't be a problem anymore with #22113.

@mdo mdo closed this as completed in #22113 Mar 5, 2017
@mdo mdo mentioned this issue Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants