-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nav-link active class has no more css style #22470
Comments
The docs do say " No active states are included in the base nav." (see https://v4-alpha.getbootstrap.com/components/navs/#base-nav) and I guess the point of having that active class in the base nav examples is to show that indeed, there's no extra styling. agree though that this is mentioned in a very subdued way in the doc there, and there's little point in all the following examples including the class to prove that there's no actual style defined... |
My fault, doesn't read the warning :-(
|
why do pills have an active style but links do not? |
not a fan of adding those comments to all the examples. however, made the note about missing active states in base navs more prominent (and added further accessibility advice) here #22472 |
Yes seen it. Thanks |
Sorry, I have another issue about pill.(v4 alpha6) |
https://v4-alpha.getbootstrap.com/components/navs/#base-nav
Still in v4-dev branch, and doesn't fund any related issues about "active" class on "nav-link" in basic "nav" element. The first link have an active class which doesn't provide any style,
Css is defined for .nav-link.active only for :
.nav-tabs
.nav-pills
.navbar-light .navbar-nav
.navbar-inverse .navbar-nav
Looks like v4-dev never had a active class available for basic nav-link
Maybe need to update the doc, or the _nav.scss
The text was updated successfully, but these errors were encountered: