Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inner white border effect on popovers #23763

Closed
andresgalante opened this issue Aug 31, 2017 · 2 comments
Closed

Remove inner white border effect on popovers #23763

andresgalante opened this issue Aug 31, 2017 · 2 comments

Comments

@andresgalante
Copy link
Collaborator

The popovers have an inner white border on the headers, it's a nice effect but I think it makes the styles too opinionated, plus it's a code overhead to generate them and it makes it harder to convert popovers from px to rems.

How about we remove that effect and simplify the popover code?

@andresgalante andresgalante changed the title Inner white border effect on popovers Remove inner white border effect on popovers Aug 31, 2017
@mdo
Copy link
Member

mdo commented Aug 31, 2017

Yeah, I'm fine nuking them :D.

@andresgalante
Copy link
Collaborator Author

@mdo Cool, I'll send a PR removing them and changing the units to rem today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants