Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable ratios for responsive embeds #25906

Closed
c0defre4k opened this issue Mar 21, 2018 · 2 comments
Closed

Variable ratios for responsive embeds #25906

c0defre4k opened this issue Mar 21, 2018 · 2 comments
Labels
css feature has-pr v4

Comments

@c0defre4k
Copy link

Since colors, spacers, sizes, ... are generated based on map I think it would be just as suitable to introduce a $embed-ratios variable.

See this gist for an implementation example,
@midzer
Copy link
Contributor

midzer commented Mar 21, 2018

I think this might come handy in certain situations 👍

@MartijnCuppens MartijnCuppens mentioned this issue Mar 21, 2018
Merged
@MartijnCuppens
Copy link
Member

Made a PR for this 2 days ago (see #25894)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css feature has-pr v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@XhmikosR @Johann-S @midzer @MartijnCuppens @c0defre4k