Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button transition with $enable-shadows:true not working properly #26478

Closed
wojtask9 opened this issue May 10, 2018 · 2 comments
Closed

button transition with $enable-shadows:true not working properly #26478

wojtask9 opened this issue May 10, 2018 · 2 comments

Comments

@wojtask9
Copy link
Contributor

see: http://jsfiddle.net/aze0jzj5/6/

steps to reproduce:
click and hold button for 1sec and then release mouse button

result:
focus outline flickers

This is because BS tries transition from box-shadow: inset to box-shadow: outer

According to https://github.com/twbs/bootstrap/blob/v4-dev/scss/mixins/_buttons.scss#L89
you can disable inset by setting $btn-active-box-shadow:none but that will not work because in other places passing 'none' to box-shadow causes incorrect css rule (for example box-shadow: none, 1px 1px 1px black)

Solution that can be worth consider:
http://tobiasahlin.com/blog/how-to-animate-box-shadow/

@mdo
Copy link
Member

mdo commented Dec 17, 2018

I believe this was fixed when we added a check for none to the buttons mixins.

@mdo mdo closed this as completed Dec 17, 2018
@wojtask9
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants