Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button font size #27680

Closed
mkbctrl opened this issue Nov 16, 2018 · 2 comments
Closed

Button font size #27680

mkbctrl opened this issue Nov 16, 2018 · 2 comments

Comments

@mkbctrl
Copy link

mkbctrl commented Nov 16, 2018

Hello fellow developers,

not sure if it's a bug or a feature, that I stumbled upon.
Once customizing bootstrap variables, with custom vars I have discovered the the .btn class is using an $font-size-base variable in the mixin, instead of $btn-font-size variable.

screenshot 2018-11-16 at 16 07 44

thus, defining your own, custom $btn-font-size in the bootstrap variables will not take effect.

I have Bootstrap in 4.1.1 version

@alecpl
Copy link
Contributor

alecpl commented Nov 16, 2018

If you checked current code you'd find this is fixed: https://github.com/twbs/bootstrap/blob/v4-dev/scss/_buttons.scss#L16

@XhmikosR
Copy link
Member

#26908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants