Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light Mode Mixins #29551

Closed
josephgeis opened this issue Oct 19, 2019 · 5 comments · Fixed by #32763
Closed

Dark/Light Mode Mixins #29551

josephgeis opened this issue Oct 19, 2019 · 5 comments · Fixed by #32763

Comments

@josephgeis
Copy link

I'd like to help push forward with #27514 by implementing a mix-in for dark mode or light mode that can be used by users and throughout the Bootstrap source code. I will file a pull request with my improvements when I'm finished (if this sounds OK).

@josephgeis josephgeis changed the title Dark/Light Mode Mixin Dark/Light Mode Mix-in Oct 19, 2019
@mdo mdo changed the title Dark/Light Mode Mix-in Dark/Light Mode Mixins Oct 20, 2019
@piernik
Copy link

piernik commented Oct 31, 2019

If I can. I see that You are planning to add dark theme to bootstrap which is great.
But I also see that You are connecting dark theme with prefers-color-scheme.
I think it suppose to be independent. Some users might want to have dark theme while having light system theme. Or maybe dark theme would be tirggered during day and night?

@josephgeis
Copy link
Author

@piernik I'm simply just writing a mixin for Sass for the media query. If someone wanted to force the theme, they could write the theme as a class and @extend it in the @include dark-scheme {}.

@ysds
Copy link
Member

ysds commented Dec 1, 2019

@juniorRubyist I'm not sure your suggestion. Can you create a PR or show demo on https://www.sassmeister.com/ for clarity?

@josephgeis
Copy link
Author

@ysds #29552

@ysds
Copy link
Member

ysds commented Dec 1, 2019

@juniorRubyist thanks, I missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants