Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Column order classes missing Sass variable name #40816

Closed
3 tasks done
TobiGr opened this issue Sep 11, 2024 · 2 comments · Fixed by #40821
Closed
3 tasks done

[Docs] Column order classes missing Sass variable name #40816

TobiGr opened this issue Sep 11, 2024 · 2 comments · Fixed by #40821

Comments

@TobiGr
Copy link
Contributor

TobiGr commented Sep 11, 2024

Prerequisites

Describe the issue

The docs say at https://getbootstrap.com/docs/5.3/layout/columns/#order-classes:

Order classes

Use .order- classes for controlling the visual order of your content. These classes are responsive, so you can set the order by breakpoint (e.g., .order-1.order-md-2). Includes support for 1 through 5 across all six grid tiers. If you need more .order-* classes, you can modify the default number via Sass variable.

It is not clear which Sass variable needs to be modified. Adding the var name would be helpful.

Reduced test cases

Not applicable to docs, I guess?

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Firefox

What version of Bootstrap are you using?

v5.3.3

@julien-deramond
Copy link
Member

Thanks for opening this issue @TobiGr

I think that the sentence is even misleading, as there's not really a Sass variable to modify. I mean, there is, but it's the content of $utilities that must be updated, because the responsive order utility is built like this:

"order": (
responsive: true,
property: order,
values: (
first: -1,
0: 0,
1: 1,
2: 2,
3: 3,
4: 4,
5: 5,
last: 6,
),
),

@julien-deramond
Copy link
Member

Tried something in #40821. See you there for comments and feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants