Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect NixOS platform #18

Open
fricklerhandwerk opened this issue May 2, 2022 · 0 comments
Open

Automatically detect NixOS platform #18

fricklerhandwerk opened this issue May 2, 2022 · 0 comments

Comments

@fricklerhandwerk
Copy link
Member

fricklerhandwerk commented May 2, 2022

Is your feature request related to a problem? Please describe.
Running the codelab on NixOS requires a manual step.

Describe the solution you'd like
Provide a wrapper for http_archive that additionally takes a mapping of platforms to a list of patches. See _detect_host_platform() in rules_nixpkgs for an example, or is_supported_platform() for a much simpler one.

Another way to detect NixOS: https://discourse.nixos.org/t/detect-that-bash-script-is-running-under-nixos/11402

Describe alternatives you've considered
Keep the manual step. Whoever uses NixOS will be confident enough to uncomment two lines in WORKSPACE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant