fix: enable experimental features #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Apr 10, 2024
| @@ -126,6 +126,7 @@ pub fn describe_derivation(args: &DescribeDerivationArgs) -> Result<DerivationDe | |||
| .arg(format!("lib={}", args.lib.path().to_string_lossy())) | |||
| .args(["--json", "--expr", expr]) | |||
| .arg("--impure") | |||
| .args(["--extra-experimental-features", "flakes nix-command"]) | |||
There was a problem hiding this comment.
By the way, I haven't looked at it, this Rust API for the Nix CLI was presented at NixCon two years ago I believe by Flox. Don't know if it's really helpful here, but I'm mentioning it just in case.
There was a problem hiding this comment.
It isn't unfortunately! When I started this project, I investigated it, and there was actually a prototype that used it. But I found it not powerful enough to do what we needed to do with it unfortunately.
thufschmitt
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--extra-experimental-features "flakes nix-command"to thenixinvocations.Motivation
The Genealogos README does mention that
flakesandnix-commandmust be enabled for it to function, and we could have gone with a similar approach for nixtract. But, since this flag is a no-op on systems whereflakesandnix-commandare already enabled anyway, we can set it here and avoid users having to set it manually.Either way, we are limited to a version of nix that supports these features.
Checklist
Checklist before merging:
[ ] README.md up-to-date