Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request] nixpkgs_python_configure support for 'quiet' attribute #130

Closed
thundergolfer opened this issue Jun 12, 2020 · 2 comments
Closed

[request] nixpkgs_python_configure support for 'quiet' attribute #130

thundergolfer opened this issue Jun 12, 2020 · 2 comments

Comments

@thundergolfer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In 0.7.0 we got support for quiet attribute on nixpkgs_package. It's a nice feature, but when using nixpkgs_python_configure it's hidden from the user.

Describe the solution you'd like

Access to this attribute from nixpkgs_python_configure

Additional context

Would you accept a PR?
@thundergolfer thundergolfer changed the title [request] nixpkgs_python_configure support for quiet attribute [request] nixpkgs_python_configure support for 'quiet' attribute Jun 12, 2020
@aherrmann
Copy link
Member

That's a good idea, it would also be a useful addition to other rules that call nixpkgs_package.

Would you accept a PR?

Yes, a PR would be very welcome.

@thundergolfer thundergolfer mentioned this issue Jun 16, 2020
Merged
@mboes
Copy link
Member

mboes commented Aug 5, 2020

Fixed in #131.

@mboes mboes closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mboes @aherrmann @thundergolfer