Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide rules_pkg rpmbuild and git toolchain #412

Open
malt3 opened this issue Sep 4, 2023 · 1 comment
Open

Provide rules_pkg rpmbuild and git toolchain #412

malt3 opened this issue Sep 4, 2023 · 1 comment
Labels
P3 minor: not priorized type: feature request

Comments

@malt3
Copy link
Collaborator

malt3 commented Sep 4, 2023

Is your feature request related to a problem? Please describe.

rules_pkg depends on a rpmbuild toolchain to be available to package binaries as rpms in the pkg_rpm rule.
There is a method to load rpmbuild from the host path (which is non-hermetic).

EDIT: rules_pkg also has a git toolchain. I think we could provide that as well. The same points apply.

Describe the solution you'd like

nixpkgs contains rpmbuild and could provide a rpmbuild toolchain as required by rules_pkg.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Not provide rpmbuild via rules_nixpkgs and have failing builds if developers don't have it on their system
  • Package rpmbuild myself

Additional context

I would be happy to implement this (if the maintainers like the idea).

@malt3 malt3 changed the title Provide rules_pkg rpmbuild toolchain Provide rules_pkg rpmbuild and git toolchain Sep 6, 2023
@benradf
Copy link
Member

benradf commented Sep 6, 2023

Hi @malt3, thanks for your interest in adding this functionality.

A pull request would be welcome. I'd suggest putting the new toolchains under toolchains/pkg/, and if you have the time to add an example as well, that would be great.

@benradf benradf added the P3 minor: not priorized label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 minor: not priorized type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants