-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS max encoders limitation issue #17
Comments
Hi @yahmad,
Not at all, there was no pre-existing Github issue.
The limitation on creating 3 encoders exists in VideoToolbox.framework and is hardware specific. From what we've been told by Apple engineers the iPhone X is not subject to this fixed limit, and multiplexes the hardware resources if you ask for many simultaneous encoders. We have a test case which we will update to validate this on the iPhone X. Right now we just make sure that each device we test on can encode up to 3 video streams in H.264. I believe there is a way to fix this for all devices, but in order to do this we need some internal WebRTC changes that are coming as a part of 2.3.0.
We are going to have a short preview and beta period for 2.3.0 because it involves an upgrade of the version of WebRTC that we depend on. Expect 2.3.0-preview1 in the next few weeks. Once that release has landed we can start taking a look at this issue again in the lead up to 2.3.0. In the meantime, the only workaround I can suggest is to either:
Regards, |
@ceaglest Thanks for the quick response - and the useful feedback! I will make a note to test on the iPhone X, and keep an eye out for the preview to give it a test. 👍 |
Hi @yahmad, We have now released 2.3.0 which is based upon WebRTC 67. While I didn't get a chance to work on this bug directly, the updated WebRTC internals give us a lot more power over how video codecs are managed. I still think this problem is solvable, so I'll be doing some more investigation on it next week. Thanks for your patience, |
Thanks for the update, Chris. A fix for this would be very useful. Yasir |
hello func connectionTwilio()
func prepareLocalMedia() {
|
func setupPreview()
|
@Girish-iweb do you think the the issue you are reporting related to |
@piyushtank bellow my code self.prepareLocalMedia()
// APIManager.sharedInstance.centerToast(messsage: "Connecting...", view:self.view) |
This issue is mentioned in the Twilio changelog under known issues:
I just wanted to have this tracked against an issue, and to find out what the status is? (I can't find a related open issue). Sorry for being a nuisance. 😉
The issue is quiet severe, as it limits the ability to create cross-platform multi-party P2P rooms, as only an Android device can provide video tracks to more than three other participants. Can you give any progress updates on this issue, or an ETA on a fix?
Video iOS SDK
TwilioVideo v2.1 via CocoaPods
The text was updated successfully, but these errors were encountered: