-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with 960x540 video & network congestion #116
Comments
Alse there were a record in log: ERROR:TwilioVideo:[Platform]:Fatal runtime capture error: Error Domain=AVFoundationErrorDomain Code=-11800 "The operation could not be completed" UserInfo={NSUnderlyingError=0x17064d500 {Error Domain=NSOSStatusErrorDomain Code=-12785 "(null)"}, NSLocalizedFailureReason=An unknown error occurred (-12785), NSLocalizedDescription=The operation could not be completed}, code -11800 |
@aobondar Setting video constraints should not cause a crash. Can you provide more details about your use case and how you are applying video constraints? Also, can you send details about the device and iOS version you are running your app on, along with a stack trace of all the threads? Thanks. |
Probably, you're right, but when i removed the constraints, i started working well again. Reproduced 4/4.
Reproducing on iOS 10.1 and 10.2. iPhone 6 & iPhone 6s. Crashdump is in attachment Update: oops. Here's symbolificated one. |
@aobondar We have removed Changelogs - https://www.twilio.com/docs/api/video/changelogs/ios#100-april-26-2017 I have created following branch where 16:9 aspect ratio video constraints is applied on Quickstart. Try running the quickstart from the branch and let me know if you still get the crash on setting the constraints. Branch: https://github.com/ptankTwilio/video-quickstart-swift/tree/video-constraints-test Code which sets up the up the constraint: https://github.com/ptankTwilio/video-quickstart-swift/blob/video-constraints-test/VideoQuickStart/ViewController.swift#L174 |
Ah, i see, sorry for misinformation - it was a nonrefactored snipped, just before mowing to GA. The correct one is:
Thank you for branch, i think i'll be able to continue investigation after several days, and i will send more info ASAP. |
@aobondar I have used the code snippet you have sent to add and remove video on branch Branch: Branch: https://github.com/ptankTwilio/video-quickstart-swift/tree/video-constraints-test Quickstart app uses the code snippet you sent: Please try running Quickstart app from this branch and let me know if you are still observing the crash. |
In one of our test runs (1.0.0 GA) we experienced the same crash (iPhone SE), but we use the following constraints:
And this was the call stack:
|
@ptankTwilio Sorry for not answering so long. I've encountered the same crash on given branch. Here i attach the stacktraces, captured from XCode on crash, and all the build symbols for investigation. https://drive.google.com/open?id=0B2OVY0Xc-YAucVpFbk5DN0FVcUk |
Quick update: I was able to reproduce the crash in poor network conditions when frames are downscaled at the front of the capture pipeline (not the encoder). I'm looking into a fix this afternoon, and am planning to include it in our next 1.0.1 release. A temporary workaround (though not a great one) is to choose 1280x720 instead of 960x540.
|
I've fixed this crash, and our QA team will begin internal validation tomorrow. Expect the fix to land in 1.0.1 over the next few business days. |
@ceaglest, thank you for help! Looking forward for new build! |
We've just released 1.0.1 of Twilio Video which contains the fix for this crasher. Feel free to capture at 960x540 in whatever network conditions you want using the new release. https://www.twilio.com/docs/api/video/changelogs/ios#101-may-15-2017 Best, |
Nice work, thank you so much! |
@ceaglest, thank you very much! |
Closing this issue, since it was fixed in 1.0.1. |
Hi there!
I'm using TwillioVideo GA lib for 1-to-1 video conversation. It used to work well, but when i set the 16:9 video dimension for capturer it started crashing. The same scenario: after ~10 secs the video quality starts degradating, and after the calle have a crash with the same callstack:
All the other threads are waiting. I user swift3, latest available version of lib. Your help would be appreciated!!!
The text was updated successfully, but these errors were encountered: