Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Embed workspace documents" doesn't work properly #384

Open
makiz1999 opened this issue Nov 12, 2024 · 7 comments · Fixed by #385
Open

"Embed workspace documents" doesn't work properly #384

makiz1999 opened this issue Nov 12, 2024 · 7 comments · Fixed by #385

Comments

@makiz1999
Copy link

Describe the bug
I am trying to use embeddings to create context awareness of myry so that I can ask a current directo chatbot for details within a file. I have a python file with a simple function:
image

And this is chatbot response:
image

Logging
After embedding workspace documents:
image

API Provider
image

Chat or Auto Complete?
Chat

Model Name
codellama:7b-instruct

Desktop (please complete the following information):

  • OS: macOS: Sequoia 15.1
  • Version v3.18.12
@rjmacarthy
Copy link
Collaborator

Hey, thanks for the report. Please could you explain why you are using codellama:7b-instruct as the embedding model?

@makiz1999
Copy link
Author

Hey, thanks for the report. Please could you explain why you are using codellama:7b-instruct as the embedding model?

Hi, I was experimenting with different models to see if the output or quality of responses would change. From my observations, responses are pretty much similar to any model. I get a similar error when using llama3.1:latest:
image

image

image

The response with llama3.1:latest is different but still doesn't make sense and reference the actual file.

Do you know by chance how to fix it? Thanks

@rjmacarthy
Copy link
Collaborator

Interesting, would have to investigate, maybe something changed with LanceDB recently...

@rjmacarthy
Copy link
Collaborator

Hey, I just released version 3.19.0. I would recommend to use https://ollama.com/library/all-minilm for the embedding model, this is the one I have had best results with in the past, let me know if you find a better one.

Many thanks!

@makiz1999
Copy link
Author

Hey, I just released version 3.19.0. I would recommend to use https://ollama.com/library/all-minilm for the embedding model, this is the one I have had best results with in the past, let me know if you find a better one.

Many thanks!

Thank you so much! I will try to test it out soon. Do you have recommendations for chat and FIM models as well?

@makiz1999
Copy link
Author

I have installed all-minilm and set it up as the embedding model. It still doesn't work as expected unfortunately and can't reference other files. Here is the error after pressing 'Embed workspace documents'.
image

@rjmacarthy
Copy link
Collaborator

I think maybe your folder has a space in the name? Please try to remove the space for now. I'll fix that bug in the next release.

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants