Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: still copy after each msg_parsed?? #674

Open
skygragon opened this issue Aug 23, 2022 · 1 comment
Open

Q: still copy after each msg_parsed?? #674

skygragon opened this issue Aug 23, 2022 · 1 comment

Comments

@skygragon
Copy link

mbuf_split is called after each command parsed? what if client send multiple commands in pipeline?

image

@TysonAndre
Copy link
Collaborator

TysonAndre commented Aug 23, 2022

Duplicate of #158 - see discussion there.

The splitting logic is still correctly splitting the buffers

In practice, having a small default mbuf size limits the worst case performance impact of splitting commands if a client does support pipelining outgoing commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants