Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/ramda vs npm-ramda #163

Closed
wclr opened this issue Apr 2, 2017 · 15 comments
Closed

@types/ramda vs npm-ramda #163

wclr opened this issue Apr 2, 2017 · 15 comments
Assignees

Comments

@wclr
Copy link
Contributor

wclr commented Apr 2, 2017

Who is actually maintaining?
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ramda/index.d.ts

Maybe it is worth to combine the efforts and purth to @types/ramda that seems to be more consistent?

@KiaraGrouwstra
Copy link
Member

Yeah, the version at DefinitelyTyped is somewhat ancient at this point; see also #134, #142, #148. Currently the recommended way of installing the types is using the command in the readme.
Maybe I should leave this open to make it more visible.

@schickling
Copy link

@tycho01 could you merge this repo to DefinitelyTyped until microsoft/types-publisher#4 is solved?

@KiaraGrouwstra
Copy link
Member

Hi @schickling, I made one here now. Note I have no special powers here, anyone can do it. :)

@wclr
Copy link
Contributor Author

wclr commented Apr 29, 2017

@tycho01 wanted to ask how npm-ramda published that can be installed using npm install types/npm-ramda but package name is @types/ramda? what is actually types/, tt is not a scope right?

@KiaraGrouwstra
Copy link
Member

KiaraGrouwstra commented Apr 29, 2017

Fair question. This was part of the reference package.json linked in the @types guidelines. I imagine @blakeembrey would know more. I suppose it'd relate to intended names within @types's npm super-repo (or whatever that's called). You may notice that Angular has similarly grouped their packages into an @angular/ namespace, so I guess this is similar, but for this types org.

@wclr
Copy link
Contributor Author

wclr commented Apr 29, 2017

there is types/npm-ramda, not @types/npm-ramda (the later doesn't work so you can do npm install @types/npm-ramda

@KiaraGrouwstra
Copy link
Member

Seems you're right. Looks like Angular has the @ in the package name as well, so not sure why they're installed with it, this repo without. I don't know the answer, so I'll have to defer this one.

@wclr
Copy link
Contributor Author

wclr commented Apr 29, 2017

Who is currently responsible the package for publication?

@KiaraGrouwstra
Copy link
Member

I fear this is open-source. One guy started Ramda typings, another took over, at one point I got active, then things moved to this repo... and now I don't quite have the time as I'd hoped.
I know about these typings, Blake knows about this org... I sorta figured out how to make things work with what DefinitelyTyped expected, but then... those many errors.

@blakeembrey
Copy link
Member

I don't understand the conversation/question, what do you mean who is responsible for "publishing the repo"? The NPM install in the README is installing from git so there's no publication involved. If you're talking about DefinitelyTyped, no one is responsible for publishing there either - that's a feature where I've been told they expect to see only drive-by contributions and not one person managing a package (it's pretty hard today to manage one package since it's all one repo and subscribing means dozens of issues/PRs a day, none related to your package). Installation from Git can use any package name (see package.json) so we've been using it as a hack to allow people to install the definitions until redirects are supported.

@wclr
Copy link
Contributor Author

wclr commented Apr 30, 2017

@blakeembrey ah) thanks types/npm-ramda is just a git address =) This what put me into confusion, thought npm clients support only github:types/npm-ramda short uri, not just types/npm-ramda

Installing directly from git not very good thing though.

@blakeembrey
Copy link
Member

No, it's not, hence saying it's a hack. But it's all that's possible today. If you're interested in building better tooling to contribute to DefinitelyTyped, I'd love to see it but in the current state I haven't seen anything to make it possible.

@ahstro
Copy link

ahstro commented Aug 1, 2017

What's the state here? Saw that @types/ramda just had a push a couple of days ago, so assuming it isn't "ancient" anymore? Are the two going to get merged?

@KiaraGrouwstra
Copy link
Member

@ahstro expect updating that to become part of #173.

@ikatyang ikatyang self-assigned this Aug 15, 2017
@KiaraGrouwstra
Copy link
Member

WIP at #191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants