Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all assemble and deploy rules: maven_assembly; npm_deployment, etc. #331

Open
alexjpwalker opened this issue Jan 10, 2022 · 3 comments

Comments

@alexjpwalker
Copy link
Member

The top-level packages are named npm, pip, maven etc. while the rule names begin with assemble and deploy - there is a misalignment here.

@alexjpwalker
Copy link
Member Author

alexjpwalker commented Jan 11, 2023

npm, pip etc. are clearly stronger domains than assemble and deploy. This gives us maven_assemble.

Now, assemble and deploy are verbs, which does not really fit the paradigms of a declarative language like Bazel.

So the refactor we're leaning towards is:

  • assemble_maven => maven_assembly
  • deploy_maven => maven_deployment
  • assemble_pip => pip_assembly
  • deploy_npm => npm_deployment

(and so on and so forth.)

@alexjpwalker alexjpwalker changed the title assemble and deploy: Package structure not aligned with rule names Rename all assemble and deploy rules: maven_assembly; npm_deployment, etc. Jan 11, 2023
@alexjpwalker
Copy link
Member Author

alexjpwalker commented Jan 12, 2023

Let's make this change once we condense the GitHub repos, so that it's easier to propagate. cc @haikalpribadi .

@alexjpwalker alexjpwalker self-assigned this Jan 12, 2023
@alexjpwalker alexjpwalker added this to the Technical Debt milestone Jan 12, 2023
@haikalpribadi
Copy link
Member

Indeed, let's rename them, but after we collapse the repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants